Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI flags in testing pipeline #22788

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Fix CLI flags in testing pipeline #22788

merged 5 commits into from
Sep 12, 2023

Conversation

CatB1t
Copy link
Contributor

@CatB1t CatB1t commented Aug 30, 2023

Fix an issue where passing CLI arguments to test doesn't reflect on Hypothesis strategies.

@CatB1t CatB1t requested a review from sherry30 August 30, 2023 12:15
@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@CatB1t CatB1t marked this pull request as ready for review August 30, 2023 12:18
sherry30
sherry30 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@CatB1t CatB1t merged commit 7bccf71 into ivy-llc:main Sep 12, 2023
102 of 133 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
@CatB1t @iababio
fix(testing): update CLI flags to be dynamically retrieved (ivy-llc#2…
cfdd96f 
…2788)
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
@CatB1t @druvdub
fix(testing): update CLI flags to be dynamically retrieved (ivy-llc#2…
1475a3e 
…2788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherry30 sherry30 sherry30 approved these changes

Assignees

@djl11 djl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CatB1t @sherry30 @djl11